-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add 360 and ortho cameras #705
base: master
Are you sure you want to change the base?
✨ add 360 and ortho cameras #705
Conversation
Thank you for the contribution. It's great to have support for additional camera modes. Two small things I think would be prudent to have before I hit the merge button:
You don't have to do these if you don't want to; I'd be happy to implement these changes/additions myself in the coming weeks as cycles come up. Cheers! |
Thanks for your quick reply!
|
9963578
to
b9cf301
Compare
b9cf301
to
30fe0fc
Compare
Let me know if you still have some fixes in mind ! |
Hate to jump on this but has this been added, I have a insta 360 1 Inch camera I wanted to test out, also if @ThomasParistech could provide some documentation on best usage of 360 data that would be awesome. |
The goal of this PR is to support the rendering of 360 views once the model has been trained with normal images Camera models are implemented, but input data is currently considered as coming from a standard perspective camera But we could as well add the possibility to define the camera type to use during training, or even have multimodal training. |
Hi! Thanks for the great work. How does it work headlessly, can I generate a 360 video from the perspective camera path file? |
any chance to merg this into the branch or how can I test this.. documentation would be appreciated :) |
The 360 camera model is actually quite simple. |
Adding 360 support would be great, Agisoft currently supports 360 images. As well would be great to get agisoft support direct. |
b04280e
to
c1bd002
Compare
@Tom94 Any suggestion / improvement to do to help this PR being merged ? :) Many thanks ! |
Hi, sorry for the radio silence -- I actually wanted to merge it a long time ago, but ended up deciding against it in favor of a different approach. Instant NGP nowadays has a |
Thanks for the reply 👍 |
Update 'pixel_to_ray' method to handle orthographic and environment (360°) cameras