Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sam 1869 battery adjust losses #1241

Merged
merged 26 commits into from
Nov 14, 2024
Merged

Sam 1869 battery adjust losses #1241

merged 26 commits into from
Nov 14, 2024

Commits on Oct 22, 2024

  1. Add a few required variables. Need to make a lot of decisions to use … 

    …these
    @brtietz
    brtietz committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    687e0c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Merge branch 'develop' of https://github.com/NREL/ssc into sam_1869_b… 

    …attery_adjust_losses
    @brtietz
    brtietz committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    54cd4dc View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Merge branch 'develop' of https://github.com/NREL/ssc into sam_1869_b… 

    …attery_adjust_losses
    @brtietz
    brtietz committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    12988d2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/NREL/ssc into sam_1869_b… 

    …attery_adjust_losses
    @brtietz
    brtietz committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    fe43909 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix_haf_for_custom_generation' into sam_1869_battery_ad… 

    …just_losses
    @brtietz
    brtietz committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d9120a4 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Implement adjust losses within the capacity model. Not yet fully hook… 

    …ed up to cmod battery
    @brtietz
    brtietz committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    efd4d87 View commit details
    Browse the repository at this point in the history

  2. mid-stream updates for power losses

    @brtietz
    brtietz committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e1b08df View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' of https://github.com/NREL/ssc into sam_1869_b… 

    …attery_adjust_losses
    @brtietz
    brtietz committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8f747ed View commit details
    Browse the repository at this point in the history

  4. First cut change of definition for powerflow AC losses to match new c… 

    …onvention (PV only applies to PV when AC connected
    @brtietz
    brtietz committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    638998f View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Add adjust losses to batt stateful, clean up cmod batt to fix seh exc… 

    …eption (still doesn't relay losses properly
    @brtietz
    brtietz committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7bb945e View commit details
    Browse the repository at this point in the history

  2. Test updates for new capacity and availability loss conventions

    @brtietz
    brtietz committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f8a604b View commit details
    Browse the repository at this point in the history

  3. First cut at availability losses testing. Revealed that DC battery st… 

    …ill has a problem with a giant resistor that doesn't exist
    @brtietz
    brtietz committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    559122e View commit details
    Browse the repository at this point in the history

  4. Add automated and manual dispatch tests, add current restriction to a… 

    …vailability losses
    @brtietz
    brtietz committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    282d2a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Pass data through all compute modules to losses and powerflow code

    @brtietz
    brtietz committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ebc31f7 View commit details
    Browse the repository at this point in the history

  2. Add fallback code if batt_adjust is not defined

    @brtietz
    brtietz committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    bd44be4 View commit details
    Browse the repository at this point in the history

  3. Refactor max power and current to be functions instead of calculating… 

    … in each individual location
    @brtietz
    brtietz committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e8fd9ed View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Merge branch 'develop' of https://github.com/NREL/ssc into sam_1869_b… 

    …attery_adjust_losses
    @brtietz
    brtietz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7beb55e View commit details
    Browse the repository at this point in the history

  2. Fix typo in manual dispatch power vs current

    @brtietz
    brtietz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    2ac26d8 View commit details
    Browse the repository at this point in the history

  3. Run adjustment code based on which variables are actually available

    @brtietz
    brtietz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    efb7743 View commit details
    Browse the repository at this point in the history

  4. Improved error handling for battery adjust losses

    @brtietz
    brtietz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d05b4f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Pass analysis period to haf setup function

    @brtietz
    brtietz committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3cb0df8 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Use correct nyears to account for system lifetime mode == 0

    @brtietz
    brtietz committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e06f183 View commit details
    Browse the repository at this point in the history

  2. Add output for total performance adjustment loss at a given timestep

    @brtietz
    brtietz committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2bb5351 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' of https://github.com/NREL/ssc into sam_1869_b… 

    …attery_adjust_losses
    @brtietz
    brtietz committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    cc88f4e View commit details
    Browse the repository at this point in the history

  4. Make ssc variable labels consistent with UI forms, help, and the loss… 

    …es page
    @brtietz
    brtietz committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a87f41d View commit details
    Browse the repository at this point in the history

  5. bring cmod battery in line with name chage

    @brtietz
    brtietz committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3ed4abe View commit details
    Browse the repository at this point in the history