Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial setup of branch for OS 3.9.0 #146

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

initial setup of branch for OS 3.9.0 #146

wants to merge 7 commits into from

Conversation

DavidGoldwasser
Copy link
Collaborator

Test with 3.9.0.rc2 through CI

@DavidGoldwasser
initial setup of branch for OS 3.9.0
ec8c1a9 
Test with 3.9.0.rc2 through CI
@DavidGoldwasser DavidGoldwasser marked this pull request as draft November 1, 2024 23:55
@DavidGoldwasser DavidGoldwasser added this to the Measures For OS 3.9.0 milestone Nov 2, 2024
@DavidGoldwasser DavidGoldwasser self-assigned this Nov 2, 2024
@DavidGoldwasser
Copy link
Collaborator Author

DavidGoldwasser commented Nov 2, 2024 •
edited
Loading

Screenshot 2024-11-01 at 8 17 45 PM

Failure: test_aspect_ratio_low_a(Minitest::Result) [/srv/jenkins/git/openstudio-model-articulation-gem/PR-146/3/lib/measures/create_bar_from_building_type_ratios/tests/create_bar_from_building_type_ratios_test.rb:60]: Expected: "Success" Actual: "Fail"

ERROR MESSAGES
[openstudio.model.Surface] Initial area of other surface 'Surface 172' 25.546 does not equal post intersection area 25.5478
Can skip this for now or relax test in standards a bit more, but could be good to investigate changes on this from

Failure: test_aspect_ratio_low_a(Minitest::Result) [/srv/jenkins/git/openstudio-model-articulation-gem/PR-146/3/lib/measures/create_bar_from_doe_building_type_ratios/tests/create_bar_from_doe_building_type_ratios_test.rb:60]: Expected: "Success" Actual: "Fail"

Exact same error as other create_bar very similar or same test
[openstudio.model.Surface] Initial area of other surface 'Surface 172' 25.546 does not equal post intersection area 25.5478

Failure: test_eun_fail(Minitest::Result) [/srv/jenkins/git/openstudio-model-articulation-gem/PR-146/3/lib/measures/create_typical_building_from_model/tests/create_typical_building_from_model_test.rb:91]: Expected: "Fail" Actual: "Success"

@mdahlhausen DEER Pre-1975 is supposed to fail for eun building type but passes now. If that is no longer expected to fail I can update or the test.
https://github.com/NREL/openstudio-model-articulation-gem/blob/develop/lib/measures/create_typical_building_from_model/tests/create_typical_building_from_model_test.rb#L191-L203

@DavidGoldwasser
updating expected to pass for test_eun_fail
bd3f7d5 
Other two test will fe fixed with final version of standards
@DavidGoldwasser
Copy link
Collaborator Author

I confirmed just 2 failed tests which should go away next rc that uses the final 0.7.0 standards

@DavidGoldwasser
getting rid of duplicate test name
ca414de 
the one I kept by that name ran through more vintages. I didn't do anything to fix issue I see locally on mac, but CI has been running this fine.
@DavidGoldwasser
Update openstudio-model-articulation.gemspec
4587daa 
updating standards, will also probably have ext gem update
@DavidGoldwasser
Update openstudio-model-articulation.gemspec ext gem 0.8.2
01275b1
@DavidGoldwasser
ready for release
b2506f2
@DavidGoldwasser DavidGoldwasser marked this pull request as ready for review November 16, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflemin kflemin Awaiting requested review from kflemin

At least 1 approving review is required to merge this pull request.

Assignees

@DavidGoldwasser DavidGoldwasser

Labels
None yet
Projects
OpenStudio Measure Gems
Status: Pre-release tasks place holder
Milestone
Measures For OS 3.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@DavidGoldwasser