added emissions reporting for different fuel types #108

rawadelkontar · 2022-06-15T23:57:15Z

No description provided.

bonnema

I think when we get the measure looking good, we also want to update the measure XML

bonnema · 2022-06-17T13:59:47Z

lib/measures/add_ems_emissions_reporting/measure.rb

@@ -345,6 +368,9 @@ def run(model, runner, usr_args)
    ems_prgm.addLine("SET his_hr_intensity = his_hr * 1000 / #{floor_area}") # unit: kg/ft2 - changed mt to kg
    ems_prgm.addLine("SET fut_yr_intensity = fut_yr * 1000 / #{floor_area}") # unit: kg/ft2 - changed mt to kg
    ems_prgm.addLine("SET his_yr_intensity = his_yr * 1000 / #{floor_area}") # unit: kg/ft2 - changed mt to kg
+
+    #nat gas 
+    ems_prgm.addLine("SET nat_gas_intensity = nat_gas * 1000 / #{floor_area}") # unit: kg/ft2 - changed mt to kg


The units here are confusing. What are the units that are ultimately desired? kilograms per square foot? It seems like we're converting to from kilograms to metric tons then back to kilograms. Just leave it at kilograms if that is what is desired in the end.

@nllong requested metric ton (mt) . I can make the emissions intensity in metric ton per square feet. In this case we dont convert back to kg

total annual should be metric ton, but intensities are kg/ft2.

bonnema · 2022-06-17T13:59:57Z

lib/measures/add_ems_emissions_reporting/measure.rb

+    ems_prgm.addLine('SET conv = 1000000 * 60 * 60') # J to MWh (1000000J/MJ * 60hr/min * 60 min/sec)
+    ems_prgm.addLine('SET conv_kg_mt = 0.001') # kg to metric ton
+    ems_prgm.addLine('SET nat_gas = (nat_gas_val * gas / conv) * conv_kg_mt')
+


Remove extra lines

bonnema · 2022-06-17T14:00:28Z

lib/measures/add_ems_emissions_reporting/measure.rb

    ems_var5.setTypeOfDataInVariable('Summed')
    ems_var5.setUpdateFrequency('SystemTimestep')
    ems_var5.setEMSProgramOrSubroutineName(ems_prgm)
-    ems_var5.setUnits('kg/ft2')
+    ems_var5.setUnits('mt')


same units question

I will make it mt/ft2

bonnema · 2022-06-17T14:02:37Z

lib/measures/add_ems_emissions_reporting/measure.rb

+    # add natural gas intensity reporting output variable
+    out_var10 = OpenStudio::Model::OutputVariable.new('Natural_Gas_Emissions_Intensity_Var', model)
+    out_var10.setKeyValue('EMS')
+    out_var10.setReportingFrequency('hourly')



any reason you added the natural gas in the middle and then incremented the existing objects? it makes the diff messier, couldn't you just add the natural gas at the end? maybe there is a reason, but I was curious.

no reason. I will replace the natural gas, propane, fuel oil to be at the end.

…dback

bonnema · 2022-06-19T17:15:28Z

lib/measures/add_ems_emissions_reporting/measure.rb

@@ -285,6 +285,7 @@ def run(model, runner, usr_args)
    lim_type.setName('Emissions Sch File Type Limits')

    # add future schedule file
+    puts "fut_hr_file = #{fut_hr_file}"


you can probably remove this print statement

bonnema · 2022-06-19T17:15:42Z

lib/measures/add_ems_emissions_reporting/measure.rb

@@ -296,6 +297,7 @@ def run(model, runner, usr_args)
    sch_file.setMinutesperItem(60)

    # add historical schedule file
+    puts "his_hr_file = #{his_hr_file}"


you can probably remove this print statement

bonnema · 2022-06-19T17:15:59Z

lib/measures/add_ems_emissions_reporting/measure.rb

+    fut_sens = OpenStudio::Model::EnergyManagementSystemSensor.new(model, 'Schedule Value')
+    fut_sens.setKeyName("#{future_subregion} #{future_year} Future Hourly Emissions Sch")
+    fut_sens.setName('Fut_Sen')
+


remove extra line

bonnema · 2022-06-19T17:16:19Z

lib/measures/add_ems_emissions_reporting/measure.rb

-    sch_sens = OpenStudio::Model::EnergyManagementSystemSensor.new(model, 'Schedule Value')
-    sch_sens.setKeyName("#{future_subregion} #{future_year} Future Hourly Emissions Sch")
-    sch_sens.setName('Fut_Sen')
+    fut_sens = OpenStudio::Model::EnergyManagementSystemSensor.new(model, 'Schedule Value')


thanks for fixing the sensor name!

bonnema · 2022-06-19T17:16:25Z

lib/measures/add_ems_emissions_reporting/measure.rb

-    sch_sens = OpenStudio::Model::EnergyManagementSystemSensor.new(model, 'Schedule Value')
-    sch_sens.setKeyName("#{hourly_historical_subregion} #{hourly_historical_year} Historical Hourly Emissions Sch")
-    sch_sens.setName('His_Sen')
+    his_sens = OpenStudio::Model::EnergyManagementSystemSensor.new(model, 'Schedule Value')


thanks for fixing the sensor name!

bonnema · 2022-06-19T18:05:23Z

lib/measures/add_ems_emissions_reporting/measure.rb

+    ems_prgm.addLine('SET lpg_val = 323.896704')
+    ems_prgm.addLine('SET lpg = Lpg_Sen')
+    ems_prgm.addLine('SET conv = 1000000 * 60 * 60') # J to MWh (1000000J/MJ * 60hr/min * 60 min/sec)
+    ems_prgm.addLine('SET conv_kg_mt = 0.001') # kg to metric ton


you don't need to repeat setting these conversion lines

bonnema · 2022-06-19T18:05:29Z

lib/measures/add_ems_emissions_reporting/measure.rb

+    ems_prgm.addLine('SET fo1_val = 294.962046')
+    ems_prgm.addLine('SET fo1 = Fo1_Sen')
+    ems_prgm.addLine('SET conv = 1000000 * 60 * 60') # J to MWh (1000000J/MJ * 60hr/min * 60 min/sec)
+    ems_prgm.addLine('SET conv_kg_mt = 0.001') # kg to metric ton


you don't need to repeat setting these conversion lines

bonnema · 2022-06-19T18:15:20Z

lib/measures/add_ems_emissions_reporting/measure.rb

+    ems_prgm.addLine('SET fo2_val = 294.962046')
+    ems_prgm.addLine('SET fo2 = Fo2_Sen')
+    ems_prgm.addLine('SET conv = 1000000 * 60 * 60') # J to MWh (1000000J/MJ * 60hr/min * 60 min/sec)
+    ems_prgm.addLine('SET conv_kg_mt = 0.001') # kg to metric ton


you don't need to repeat setting these conversion lines

bonnema · 2022-06-19T18:15:58Z

lib/measures/add_ems_emissions_reporting/measure.rb

+    ems_prgm.addLine("SET nat_gas_em_intensity = nat_gas_em / #{floor_area}")
+    ems_prgm.addLine("SET lpg_em_intensity = lpg_em / #{floor_area}")
+    ems_prgm.addLine("SET lpg_em_intensity = fo1_em / #{floor_area}")
+    ems_prgm.addLine("SET lpg_em_intensity = fo2_em / #{floor_area}")


can we add unit comments back in? I think you said mt/ft2

yeah add units, but intensities are reported in kgCO2/ft2/year.

bonnema · 2022-06-19T18:47:13Z

lib/measures/add_ems_emissions_reporting/measure.rb

+    out_var16 = OpenStudio::Model::OutputVariable.new('FuelOil2_Emissions_Intensity_Var', model)
+    out_var16.setKeyValue('EMS')
+    out_var16.setReportingFrequency('hourly')
+


remove extra line

bonnema

looks good to me! maybe a quick measure XML update, and you can merge?

nllong

looks great! One comment regarding the units that needs addressed.

nllong · 2022-06-20T15:37:22Z

lib/measures/add_ems_emissions_reporting/measure.rb

-    ems_prgm.addLine("SET fut_yr_intensity = fut_yr * 1000 / #{floor_area}") # unit: kg/ft2 - changed mt to kg
-    ems_prgm.addLine("SET his_yr_intensity = his_yr * 1000 / #{floor_area}") # unit: kg/ft2 - changed mt to kg
+    #add emissions intensity metric
+    ems_prgm.addLine("SET fut_hr_intensity = fut_hr / #{floor_area}") # unit  mt/ft2


sorry for the confusion in the past. The units are

Total annual = metric tons (mt/year)

annual intensities = kilogram CO2e / ft2 (kgCO2e/ft^2) or (kgCO2e/ft^2/year)

nllong · 2022-06-20T15:45:18Z

From the Carbon Spec Doc.

mdahlhausen · 2022-06-21T21:18:32Z

Adding comments here per @DavidGoldwasser suggestion:

I don't think hourly emissions from one particular year are necessarily that helpful from a building design perspective. The res team is using a 30-year average of long-run marginal emissions, which I think is a more sensible approach. Thanks to Elaina Present for thinking through it.

Data here:
https://github.com/NREL/resstock/tree/develop/resources/data/cambium

I made a measure that implements it for ComStock:
https://github.com/NREL/comstock-internal/pull/119

DavidGoldwasser · 2023-06-05T22:16:24Z

@rawadelkontar I assume this isn't needed for next measure gem release? If it is lets try to get it ready to merge later this week.

added emissions reporting for natural gas

7d36d23

rawadelkontar requested a review from bonnema June 16, 2022 16:59

bonnema requested changes Jun 17, 2022

View reviewed changes

rawadelkontar requested a review from nllong June 17, 2022 20:22

added propane and fueloil fuel type and addressed Eric's comments/fee…

afda638

…dback

rawadelkontar requested a review from bonnema June 17, 2022 20:40

bonnema requested changes Jun 19, 2022

View reviewed changes

updates based on Eric's review

e4dc170

bonnema approved these changes Jun 20, 2022

View reviewed changes

nllong requested changes Jun 20, 2022

View reviewed changes

nllong mentioned this pull request Jun 22, 2022

prepping 0.6.1 release #110

Merged

kflemin marked this pull request as draft June 22, 2022 21:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added emissions reporting for different fuel types #108

added emissions reporting for different fuel types #108

rawadelkontar commented Jun 15, 2022

bonnema left a comment

bonnema Jun 17, 2022

rawadelkontar Jun 17, 2022

nllong Jun 20, 2022

bonnema Jun 17, 2022

bonnema Jun 17, 2022

rawadelkontar Jun 17, 2022

bonnema Jun 17, 2022

rawadelkontar Jun 17, 2022

bonnema Jun 19, 2022

bonnema Jun 19, 2022

bonnema Jun 19, 2022

bonnema Jun 19, 2022

bonnema Jun 19, 2022

bonnema Jun 19, 2022

bonnema Jun 19, 2022

bonnema Jun 19, 2022

bonnema Jun 19, 2022

nllong Jun 20, 2022

bonnema Jun 19, 2022

bonnema left a comment •

edited

Loading

nllong left a comment

nllong Jun 20, 2022

nllong commented Jun 20, 2022

mdahlhausen commented Jun 21, 2022

DavidGoldwasser commented Jun 5, 2023

added emissions reporting for different fuel types #108

Are you sure you want to change the base?

added emissions reporting for different fuel types #108

Conversation

rawadelkontar commented Jun 15, 2022

bonnema left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bonnema left a comment • edited Loading

Choose a reason for hiding this comment

nllong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nllong commented Jun 20, 2022

mdahlhausen commented Jun 21, 2022

DavidGoldwasser commented Jun 5, 2023

bonnema left a comment •

edited

Loading