Engage97 yearparamas #210
Open
Engage97 yearparamas #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgu2
reviewed
Sep 18, 2024
Comment on lines
301
to
304
| print(parameters) | ||
| emissions = ParamsManager.emission_categories() | ||
| # Parameters Table | ||
| print(loc_tech) |
There was a problem hiding this comment.
Remove print statements, use logging if need.
| @@ -1143,6 +1164,7 @@ function reconvert_all(load_flg){ | |||
| } | |||
|
|
|||
| function activate_paste(class_name) { | |||
| console.log(class_name); | |||
| id=key).hard_delete() | ||
| param_ids = data.get('parameter_instance', []) | ||
| for param_id in param_ids: | ||
| print(f"Deleting Loc_Tech_Param with id: {param_id}") |
There was a problem hiding this comment.
Remove print statement, use logging if need.
There was a problem hiding this comment.
Still workshopping this today... will remove
|
I'll leave the feature testing to @jmorrisnrel or @hannamocha , to make sure it meet the requirements. |
|
Functionality looks good to me, persisting and querying just fine 
|
hannamocha
approved these changes
Sep 19, 2024
postgres/.gitkeep
Outdated
There was a problem hiding this comment.
Was this an accidental add?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we change multi-year parameters for Technologies and Locactions. In the dropdown, we add the column, Build Year Offset, which exists in Technology Parameters and for Location Technology Parameters.