Add Grid Renewable Energy Fraction #426
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfarth
commented
Jul 30, 2024
adfarth
commented
Aug 2, 2024
adfarth
commented
Aug 2, 2024
adfarth
commented
Aug 2, 2024
adfarth
commented
Aug 2, 2024
adfarth
commented
Aug 2, 2024
adfarth
commented
Aug 2, 2024
adfarth
commented
Aug 2, 2024
adfarth
commented
Aug 2, 2024
adfarth
commented
Aug 2, 2024
… grid electricity serving the load and charging the batteries.
…electricity serving the load and the batteries
…n_profile() into one function
adfarth
commented
Nov 14, 2024
| m[:AnnualEleckWh] = @expression(m,p.hours_per_time_step * ( | ||
| # input electric load | ||
| sum(p.s.electric_load.loads_kw[ts] for ts in p.time_steps_with_grid) | ||
| + sum(p.s.electric_load.critical_loads_kw[ts] for ts in p.time_steps_without_grid) | ||
| # tech electric loads | ||
| # tech electric loads #TODO: Uncomment? |
There was a problem hiding this comment.
@zolanaj is this something we could uncomment, or is it still a WIP?
adfarth
commented
Nov 15, 2024
| @@ -356,7 +356,7 @@ function get_depreciation_schedule(p::REoptInputs, tech::Union{AbstractTech,Abst | |||
|
|
|||
| federal_itc_fraction = 0.0 | |||
| try | |||
| federal_itc_fraction = tech.federal_itc_fraction | |||
| federal_itc_fraction = tech.federal_itc_fraction # TODO: also check for total_itc_fraction as storage does not use federal_itc_fraction? | |||
There was a problem hiding this comment.
@Bill-Becker this doesn't need to be part of this PR, but it looks like you updated this function to include storage. However, the storage itc input has a different name, so the warning below will always appear for storage and it looks like itc will be set to 0 in determining the storage depreciation schedule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
@warn "No emissions reduction constraints added, as BAU emissions have not been calculated."Nice to haves:
cambium_emissions_profile()andcambium_clean_energy_fraction_profile()into one function that can be used for both emissions and clean energy fraction (just to reduce the amount of code)