-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Total water use outputs #1786
Total water use outputs #1786
Conversation
I'm on the fence here. On one side, I can see it being a useful output. On the other hand, it has the potential to be misleading/misinterpreted because it's really the total water use associated only with mixed temperature water draws, as we do not model cold water draws/use (though there's a feature request for it). |
We discussed this during our call this morning and are leaning towards not proceeding with this change. At the point at which we model all (i.e., cold water uses) as described in #1421, then it would make sense to add it. I'll leave this open for another week or two in case anyone else has further comments. |
So in the future, if we modeled all cold water uses, we'd combine cold water uses + cold water associated with mixed temperature water draws, into a single output? |
Right, we would report total water use (hot + mixed + cold) like you did here. It'd be almost exactly like this PR except there would be some additional cold-only end uses. So hopefully we could just borrow this code at the point at which we do that. |
Pull Request Description
Closes #1785.
Checklist
Not all may apply:
Schematron validator (EPvalidator.xml
) has been updatedSample files have been added/updated (openstudio tasks.rb update_hpxmls
)HPXMLtoOpenStudio/tests/test*.rb
and/orworkflow/tests/test*.rb
)openstudio tasks.rb update_measures
has been run