Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total water use outputs #1786

Closed
wants to merge 8 commits into from
Closed

Total water use outputs #1786

wants to merge 8 commits into from

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Jul 25, 2024

Pull Request Description

Closes #1785.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@joseph-robertson joseph-robertson added this to the 1.8.2 milestone Jul 25, 2024
@joseph-robertson joseph-robertson self-assigned this Jul 25, 2024
@joseph-robertson joseph-robertson marked this pull request as ready for review July 25, 2024 18:38
@shorowit shorowit added the enhancement New feature or request label Aug 6, 2024
@shorowit
Copy link
Contributor

shorowit commented Aug 6, 2024

I'm on the fence here. On one side, I can see it being a useful output. On the other hand, it has the potential to be misleading/misinterpreted because it's really the total water use associated only with mixed temperature water draws, as we do not model cold water draws/use (though there's a feature request for it).

@shorowit
Copy link
Contributor

shorowit commented Aug 6, 2024

We discussed this during our call this morning and are leaning towards not proceeding with this change. At the point at which we model all (i.e., cold water uses) as described in #1421, then it would make sense to add it.

I'll leave this open for another week or two in case anyone else has further comments.

@joseph-robertson
Copy link
Collaborator Author

joseph-robertson commented Aug 6, 2024

We discussed this during our call this morning and are leaning towards not proceeding with this change. At the point at which we model all (i.e., cold water uses) as described in #1421, then it would make sense to add it.

I'll leave this open for another week or two in case anyone else has further comments.

So in the future, if we modeled all cold water uses, we'd combine cold water uses + cold water associated with mixed temperature water draws, into a single output?

@shorowit
Copy link
Contributor

shorowit commented Aug 6, 2024

Right, we would report total water use (hot + mixed + cold) like you did here. It'd be almost exactly like this PR except there would be some additional cold-only end uses. So hopefully we could just borrow this code at the point at which we do that.

@shorowit shorowit closed this Aug 21, 2024
@shorowit shorowit deleted the total-water branch August 21, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add outputs for mixed hot water usage along with hot water usage
2 participants