Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft EP 24.2 OS 3.9 #26

Merged
merged 5 commits into from
Nov 15, 2024
Merged

draft EP 24.2 OS 3.9 #26

merged 5 commits into from
Nov 15, 2024

Conversation

DavidGoldwasser
Copy link
Contributor

@DavidGoldwasser DavidGoldwasser commented Nov 7, 2024

@dareumnam you fixed Unshaded Ann Trans and Shed Ann Trans results in 5-2a with OS 3.5, and that worked through 3.8, but those same values are gone again with 3.9? Any ideas of changes to E+ for 24.2 that I need to adjust for?

Screenshot 2024-11-08 at 8 30 44 AM

@dareumnam you fixed Unshaded Ann Trans and Shed Ann Trans results in 5-2a with OS 3.5, and that worked through 3.8, but those same values are gone again with 3.9? Any ideas of changes to E+ for 24.2 that I need to adjust for?
@DavidGoldwasser DavidGoldwasser marked this pull request as draft November 7, 2024 02:45
@DavidGoldwasser DavidGoldwasser added this to the Measures For OS 3.9.0 milestone Nov 7, 2024
@dareumnam
Copy link
Collaborator

@DavidGoldwasser As far as I know, we haven’t had a significant change like we did in OS 3.5, but I’ll double-check while reviewing this.

DavidGoldwasser and others added 4 commits November 8, 2024 10:21
Updating GitHub action to get CI running with 3.9.0 CI
Still have issues with missing values that had in rc2.
@dareumnam
Copy link
Collaborator

I updated the variable names in the measures, and now the results are popping up properly.

image

@DavidGoldwasser DavidGoldwasser marked this pull request as ready for review November 15, 2024 16:54
@DavidGoldwasser
Copy link
Contributor Author

Thanks @dareumnam interesting change for Zone to Enclosure. Now that 3.9.0 is officially out I'll merge this and make that release. I still need to go to back releases and upload zip files for archiving, and also want to update the historical Excel file for the last few releases.

@DavidGoldwasser DavidGoldwasser merged commit 6fdfbd3 into main Nov 15, 2024
1 check passed
@DavidGoldwasser DavidGoldwasser deleted the ep_24_2 branch November 15, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants