Fix Forcings Engine test compile definition for test_all
#874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
test_all
target is not compiled with-DNGEN_LUMPED_CONFIG_PATH
.This is because the definition is added with
target_compile_definitions
only totest_forcings_engine
, but if that target exists, thentest_all
will include its objects. By replacingtarget_compile_definitions
withadd_compile_definitions
, ensurestest_all
will have it defined.Changes
target_compile_definitions
->add_compile_definitions
in tests/CMakeLists.txtChecklist