Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Forcings Engine test compile definition for test_all #874

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

program--
Copy link
Contributor

This PR fixes an issue where the test_all target is not compiled with -DNGEN_LUMPED_CONFIG_PATH.

This is because the definition is added with target_compile_definitions only to test_forcings_engine, but if that target exists, then test_all will include its objects. By replacing target_compile_definitions with add_compile_definitions , ensures test_all will have it defined.

Changes

  • target_compile_definitions -> add_compile_definitions in tests/CMakeLists.txt

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@program-- program-- added bug Something isn't working build Issues related to CMake and building ngen labels Aug 16, 2024
@hellkite500 hellkite500 merged commit 2ffedf8 into master Aug 16, 2024
19 checks passed
@hellkite500 hellkite500 deleted the jsm-patch-cmake-test_all-compiledef branch August 16, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Issues related to CMake and building ngen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants