Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix array indices for horiz_interp_type assignment test #1575

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Aug 15, 2024

Description
Fixes an invalid assignment in the assignment test where it was iterating from 1 to the length of the array when it should have been iterating over the compute domain bounds when taking midpoints. This fixes gcc errors with bounds checking turned on.

How Has This Been Tested?
gcc 13 on amd box with -fcheck=all

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

bensonr
bensonr previously approved these changes Aug 15, 2024
uramirez8707
uramirez8707 previously approved these changes Aug 21, 2024
@rem1776 rem1776 merged commit d13c129 into NOAA-GFDL:main Aug 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants