Modern diag manager: Refactor buffers #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-robinson
requested changes
Aug 14, 2023
| integer, allocatable :: axis_ids(:) !< Axis ids for the buffer | ||
| integer :: field_id !< The id of the field the buffer belongs to | ||
| integer :: yaml_id !< The id of the yaml id the buffer belongs to | ||
| type :: fmsDiagOutputBuffer |
There was a problem hiding this comment.
This type should be fmsDiagOutputBuffer_type
thomas-robinson
approved these changes
Aug 15, 2023
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* refactor the buffer to always save the data as 5d * rename the output buffer type
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* refactor the buffer to always save the data as 5d * rename the output buffer type
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the output buffer to always save the data as 5d.
Updates the test after the update
Fixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheckpasses