change all fms2 fileobj instances to fms2io_fileobj #1327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-robinson
requested changes
Aug 15, 2023
Comment on lines
+1109
to
+1110
| class(FmsNetcdfFile_t), INTENT(INOUT) :: fms2io_fileobj !< Fms2_io fileobj to write to | ||
| character(len=*), INTENT(IN) :: varname !< Name of the variable |
There was a problem hiding this comment.
I don't think you should add these spaces to line up the comments because then YOU become the owner of those lines. I think you can remove the spaces between fms2io_fileobj and !< instead to make the comments line up.
| @@ -742,7 +744,8 @@ subroutine fill_subaxis(this, starting_index, ending_index, axis_id, parent_id, | |||
| integer , intent(in) :: starting_index !< Starting index of the subRegion for the PE | |||
| integer , intent(in) :: ending_index !< Ending index of the subRegion for the PE | |||
| integer , intent(in) :: axis_id !< Axis id to assign to the subaxis | |||
| integer , intent(in) :: parent_id !< The id of the parent axis, the subaxis belongs to | |||
| integer , intent(in) :: parent_id !< The id of the parent axis, | |||
There was a problem hiding this comment.
line count issue most likely
Comment on lines
+294
to
+302
| subroutine write_axis_metadata(this, fms2io_fileobj, edges_in_file, parent_axis) | ||
| class(fmsDiagAxis_type), target, INTENT(IN) :: this !< diag_axis obj | ||
| class(FmsNetcdfFile_t), INTENT(INOUT) :: fms2io_fileobj !< Fms2_io fileobj to write the data to | ||
| logical, INTENT(IN) :: edges_in_file !< .True. if the edges to this axis are | ||
| !! already in the file | ||
| class(fmsDiagAxis_type), OPTIONAL, target, INTENT(IN) :: parent_axis !< If the axis is a subaxis, axis | ||
| !! object for the parent axis | ||
| !! (this will be used to get some | ||
| !! of the metadata info) |
There was a problem hiding this comment.
Why are there so many differences here?
There was a problem hiding this comment.
spacing, uriel told me I better keep everything looking pretty
|
easier to start over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes in this pr include changing all instances of the FmsNetcdfFile_t types named
fileobjtofms2io_fileobjFixes # (issue)
How Has This Been Tested?
autotools with gcc/13.1.0 , netcdf/4.9.2, mpich/4.1.2 , hdf5/1.14.1-2 , libyaml/0.2.5
Checklist:
make distcheckpasses