Fourth reconciliation PR from production/RRFS.v1 #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantfirl
commented
Oct 29, 2024
| @@ -2367,23 +2367,23 @@ | |||
| standard_name = kinematic_surface_upward_sensible_heat_flux_of_fire | |||
| long_name = kinematic surface upward sensible heat flux of fire | |||
| units = K m s-1 | |||
| dimensions = (horizontal_loop_extent) | |||
There was a problem hiding this comment.
@grantfirl Note to self: This was messed up in #815
There was a problem hiding this comment.
This fix causes the fire behavior RT to change results. This restores the correct functionality for the two-way fire coupling.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work corresponds to #802 merged into production/RRFS.v1, except this is targeted at the develop branch. This was @haiqinli 's work.
-- Update the MYNN PBL, Smoke and subgrid cloud fraction for the RRFS.v1 code freeze.
What bug does it fix, or what feature does it add?
-- Merge the bugfix in the HAILCAST diagnostic code (unit issue) (#320)
-- Merge (#801)
Is a change of answers expected from this PR? Yes.
Issue(s) addressed
Non
Testing
Original testing for production/RRFS.v1 merge:
How were these changes tested? The changes were tested with retro runs and regression test.
What compilers / HPCs was it tested with? Intel compiler on Hera and Jet.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes.
Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera.
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
Yes, because the physics changed.
Please commit the regression test log files in your ufs-weather-model branch
Yes, the regression test log file was committed.
New testing for develop branch merge:
Ran full rt.conf on Hera. The test_changes.list and RT log were pushed into the UFSWM PR.
Dependencies
ufs-community/ccpp-physics#230
Requirements before merging