Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible restart write times (restart_fh) #1320

Open
wants to merge 2 commits into
base: dev/ufs-weather-model
Choose a base branch
from

Conversation

NickSzapiro-NOAA
Copy link
Contributor

@NickSzapiro-NOAA NickSzapiro-NOAA commented Nov 14, 2024

Pull Request Summary

This PR enables writing forecast hour defined restarts ("restart_fh") in the same way as space-delimited floating point forecast hours in model_configure attributes, like restart_fh: 0.25 2.5 6 17 24. The current restart_fh in MOM6 is for integer forecast hours. This will allow CMEPS, MOM6, CICE, and WW3 to have option of forecast hour restarts in addition to existing functionality. Restart writes are triggered when input restart_fh forecast hours are evenly divisible by a component's timestep (internally compared in units of integer seconds) and skipped otherwise.

Testing with cpld_control_gfsv17 confirms that restarts are b4b when (1) sharing common times with RESTART_N and (2) instead of RESTART_N. This feature is exercised in ufs-weather-model regression testing (see ufs-community/ufs-weather-model#2419)

Description

Building on recent netcdf restart capability, enhancement allows for arbitrary restart times. This is useful for IAU methods, for example.

Issue(s) addressed

Closes ufs-community/ufs-weather-model#2348

Commit Message

Flexible restart write times (restart_fh)

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@NickSzapiro-NOAA
Copy link
Contributor Author

Maybe I don't have permissions to suggest you as reviewers, @MatthewMasarik-NOAA @JessicaMeixner-NOAA

@MatthewMasarik-NOAA
Copy link
Collaborator

Maybe I don't have permissions to suggest you as reviewers, @MatthewMasarik-NOAA @JessicaMeixner-NOAA

@NickSzapiro-NOAA I just added myself as a reviewer for the time being. @JessicaMeixner-NOAA, @sbanihash and I will talk offline to decide on who will take the lead reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants