-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing jacobian arrays to netcdf ozone diagnostic file (#618) #619
add missing jacobian arrays to netcdf ozone diagnostic file (#618) #619
Conversation
Ctests |
Hera and Orion cycled tests of eobs, ediag, and eupd generate expected results. The standard suite of ctests on Hera, Orion, and WCOSS2 either pass or generate a non-fatal fail. The changes in this PR are ready for peer review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes look good to me.
@RussTreadon-NOAA Thank you for testing the changes and confirming that the results are reproduced. |
@jack-woollen , if you have time would you look at the changes in this PR? If the changes look good to you, an approval from you along with Haixia is sufficient for me to pass this PR onto a member of the GSI Handling Review team for merger into develop. Once this PR is in GSI develop, I'll open a g-w PR to update the GSI hash cloned by g-w. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks okay to me too. Thanks for testing it thoroughly.
Thank you @jack-woollen and @HaixiaLiu-NOAA for your reviews and approvals! |
@CoryMartin-NOAA , would you be willing to be the Handling reviewer for this PR? I can't approve and merge this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cycling tests on Hera/Orion work as expected, regression tests pass on those platforms + WCOSS2. Changes look good to me. Thank you @RussTreadon-NOAA
Description
PR #591 removed jacobian information from the netcdf ozone diagnostic file. This caused
enkf.x
to crash. This PR adds the removed ozone jacobian arrays back to the netcdf ozone diagnostic file.Fixes #618
Type of change
How Has This Been Tested?
The revised code was tested in the 20210814 18 gdas cycle of a C192L127 enkf parallel. The updated
gsi.x
created an oznstat file which was successfully processed byenkf.x
.Checklist