-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make evenly spaced ticks when threshold_values are not evenly spaced in CSI plots #302
base: develop
Are you sure you want to change the base?
Make evenly spaced ticks when threshold_values are not evenly spaced in CSI plots #302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordanschnell seems fine to me. I just wonder if it should be configurable. This could be the new default, but is it possible someone might want the original behavior instead?
cc: @btang1
@jordanschnell @zmoon thanks for adding this feature. |
sounds good - let me take a look - busy week.. |
…on by setting xtick_style = 'equal'
New tick display now requires additional plot option, original behavior is default and does not require option to be specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jordanschnell . Could you add a brief description in the doc, maybe under this line
MELODIES-MONET/docs/appendix/yaml.rst
Line 352 in bc44e39
**score_name:** csi plot only. list of scores user can choose to plot. examples are "Critical Success Index' 'False Alarm Rate' 'Hit Rate'. |
Change option name from xtick_style to threshold_tick_style Change option value from 'equal' to 'unique'
documentation added and slight change to key/value pair names. |
CSI plots with non-monotonic thresholds not displayed neatly.
threshold_list: [1,2,5,10,15,20,30,50,100,200]
Old:
Update: