Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make evenly spaced ticks when threshold_values are not evenly spaced in CSI plots #302

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

jordanschnell
Copy link
Collaborator

CSI plots with non-monotonic thresholds not displayed neatly.

threshold_list: [1,2,5,10,15,20,30,50,100,200]

Old:

plot_grp7 csi PM2 5 2024-10-24_00 2024-10-26_00 isinconus CONUS Critical Success Index

Update:

plot_grp7 csi PM2 5 2024-10-25_00 2024-10-27_00 isinconus CONUS Critical Success Index

Copy link
Collaborator

@zmoon zmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordanschnell seems fine to me. I just wonder if it should be configurable. This could be the new default, but is it possible someone might want the original behavior instead?

cc: @btang1

@btang1
Copy link
Contributor

btang1 commented Oct 29, 2024

@jordanschnell @zmoon thanks for adding this feature.
I agree with zach, that we want both old and new way of plotting. can you make is an option in yaml file?

@jordanschnell
Copy link
Collaborator Author

@jordanschnell @zmoon thanks for adding this feature. I agree with zach, that we want both old and new way of plotting. can you make is an option in yaml file?

sounds good - let me take a look - busy week..

@jordanschnell
Copy link
Collaborator Author

@jordanschnell @zmoon thanks for adding this feature. I agree with zach, that we want both old and new way of plotting. can you make is an option in yaml file?

New tick display now requires additional plot option, original behavior is default and does not require option to be specified.

Copy link
Collaborator

@zmoon zmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jordanschnell . Could you add a brief description in the doc, maybe under this line

**score_name:** csi plot only. list of scores user can choose to plot. examples are "Critical Success Index' 'False Alarm Rate' 'Hit Rate'.

Change option name from xtick_style to threshold_tick_style
Change option value from 'equal' to 'unique'
@jordanschnell
Copy link
Collaborator Author

Thanks @jordanschnell . Could you add a brief description in the doc, maybe under this line

**score_name:** csi plot only. list of scores user can choose to plot. examples are "Critical Success Index' 'False Alarm Rate' 'Hit Rate'.

documentation added and slight change to key/value pair names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants