Print a more meaningful message when decoding an object fails. #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximon18
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
The change itself is technically fine, and I can see that this is an improvement for operators, but it could also add the improved error context without discarding the actual underlying error message. Is it really wise to discard the underlying error message or is it the case that it's okay to discard it because the underlying message is not and will never be of any actual use in daignosing the cause of the probelm?
|
The decoder does indeed not provide any useful information. This is a limitation of the current error handling model in both bcder and rpki-rs. It can (and should) be fixed at some point. This PR really only provides a work-around for showing |
partim
added a commit
that referenced
this pull request
Jan 17, 2024
New * Added support for private keys marked as “EC PRIVATE KEY“ in the PEM files for TLS server configuration. ([#921]) * The rsync collector now logs stderr output of the rsync command directly instead of collecting it and logging it in one go after the commend returned. ([#290]) Bug Fixes * The `dump` command will now succeed even if certain directories or files in the repository cache are missing. ([#916]) * A more meaningful message is now printed when decoding RPKI objects fails. It will still not give much detail but at least it isn’t confusing any more. ([#917]) Other changes * Updated the `nlnetlabs-testbed` TAL to the current location and key. ([#922])
partim
added a commit
that referenced
this pull request
Jan 24, 2024
New * Added support for private keys marked as “EC PRIVATE KEY“ in the PEM files for TLS server configuration. ([#921]) * The rsync collector now logs stderr output of the rsync command directly instead of collecting it and logging it in one go after the commend returned. ([#290]) Bug Fixes * The `dump` command will now succeed even if certain directories or files in the repository cache are missing. ([#916]) * A more meaningful message is now printed when decoding RPKI objects fails. It will still not give much detail but at least it isn’t confusing any more. ([#917]) Other changes * Updated the `nlnetlabs-testbed` TAL to the current location and key. ([#922])
partim
added a commit
that referenced
this pull request
Jan 24, 2024
This PR changes the error message printed when decoding any of the RPKI objects fails from whatever wondrous thing the decoder says to a generic message stating that decoding an object of a certain expected type failed. This PR is a port of #917, originally added to the 0.13 series.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 25, 2024
Pkgsrc changes: * Bump version & re-compute cargo-depends. Upstream changes: New * Added support for private keys marked as "EC PRIVATE KEY" in the PEM files for TLS server configuration. ([#921]) * The rsync collector now logs stderr output of the rsync command directly instead of collecting it and logging it in one go after the commend returned. ([#290]) Bug Fixes * The `dump` command will now succeed even if certain directories or files in the repository cache are missing. ([#916]) * A more meaningful message is now printed when decoding RPKI objects fails. It will still not give much detail but at least it isn't confusing any more. ([#917]) Other changes * Updated the `nlnetlabs-testbed` TAL to the current location and key. ([#922]) [#916]: NLnetLabs/routinator#916 [#917]: NLnetLabs/routinator#917 [#920]: NLnetLabs/routinator#920 [#921]: NLnetLabs/routinator#921 [#922]: NLnetLabs/routinator#922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the error message printed when decoding any of the RPKI objects fails from whatever wondrous thing the decoder says to a generic message stating that decoding an object of a certain expected type failed.