Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tests #32

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,48 @@ jobs:
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Install dependencies
run: python -m pip install -U 'jupyterlab>=4.0.0,<5'
run: |
set -eux
python -m pip install -U 'jupyterlab>=4.0.0,<5' \
git+https://github.com/NII-cloud-operation/Jupyter-multi_outputs.git@feature/lab
jupyter labextension enable lc_multi_outputs

- name: Build the extension
run: |
set -eux
jlpm
jlpm lint:check
jlpm run eslint:check
python -m pip install .

jupyter labextension list 2>&1 | grep -ie "lc_run_through.*OK"
python -m jupyterlab.browser_check

jlpm install
cd ./ui-tests
jlpm install
jlpm playwright install
jlpm playwright test
cd ..

pip install build
python -m build --sdist
cp dist/*.tar.gz myextension.tar.gz
pip uninstall -y "lc_run_through" jupyterlab
pip uninstall -y myextension jupyterlab
rm -rf myextension

- uses: actions/upload-artifact@v2
npm pack
mv lc_run_through-*.tgz myextension-nodejs.tgz

- uses: actions/upload-artifact@v4
with:
name: myextension-sdist
path: myextension.tar.gz

- uses: actions/upload-artifact@v4
with:
name: myextension-nodejs
path: myextension-nodejs.tgz

test_isolated:
needs: build
runs-on: ubuntu-latest
Expand All @@ -52,7 +71,7 @@ jobs:
with:
python-version: '3.9'
architecture: 'x64'
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: myextension-sdist
- name: Install and Test
Expand Down
63 changes: 0 additions & 63 deletions .github/workflows/check-release.yml

This file was deleted.

15 changes: 10 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,12 @@ jobs:
yarn-

- name: Install dependencies
run: python -m pip install -U 'jupyterlab>=4.0.0,<5'
run: |
set -eux
python -m pip install -U 'jupyterlab>=4.0.0,<5' \
git+https://github.com/NII-cloud-operation/Jupyter-multi_outputs.git@feature/lab
jupyter labextension enable lc_multi_outputs

- name: Build the extension
run: |
set -eux
Expand All @@ -71,12 +76,12 @@ jobs:
npm pack
mv lc_run_through-*.tgz myextension-nodejs.tgz

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: myextension-sdist
path: myextension.tar.gz

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: myextension-nodejs
path: myextension-nodejs.tgz
Expand All @@ -88,10 +93,10 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v2
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: myextension-sdist
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: myextension-nodejs
- name: release
Expand Down
4 changes: 2 additions & 2 deletions ui-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"test": "jlpm playwright test"
},
"devDependencies": {
"@jupyterlab/galata": "^5.0.5",
"@playwright/test": "^1.37.0"
"@jupyterlab/galata": "^5.3.0",
"@playwright/test": "^1.48.2"
}
}
4 changes: 2 additions & 2 deletions ui-tests/tests/lc_run_through.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ test('should work unfreeze below in section button and unfreeze below all button

// freeze all cells
for(let idx of allCellIndexes) {
page.notebook.selectCells(idx, idx);
await page.notebook.selectCells(idx, idx);
await delay(100);
await page.locator('.run-through-toolbar-button__freeze').click();
}
Expand Down Expand Up @@ -181,7 +181,7 @@ test('should work unfreeze below in section button and unfreeze below all button

// freeze all cells
for(let idx of allCellIndexes) {
page.notebook.selectCells(idx, idx);
await page.notebook.selectCells(idx, idx);
await delay(100);
await page.locator('.run-through-toolbar-button__freeze').click();
}
Expand Down
Loading
Loading