Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable ssl verification on www.stcp.pt #991

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

limwa
Copy link
Member

@limwa limwa commented Oct 2, 2023

Closes #980.

This PR removes SSL verification for www.stcp.pt. This is because some systems (Android, in particular) don't have DigiCert's certificate as a root certificate.

This solution is a bit temporary, since disabling SSL verification is not really a good practice.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@limwa limwa changed the base branch from develop to master October 2, 2023 18:15
@limwa limwa enabled auto-merge October 2, 2023 18:34
@limwa limwa changed the title fix: set stcp certificate as trusted fix: disable ssl verification on www.stcp.pt Oct 2, 2023
@limwa
Copy link
Member Author

limwa commented Oct 2, 2023

Please test this on your devices!

@limwa limwa disabled auto-merge October 2, 2023 19:31
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #991 (1047345) into master (c1cf436) will decrease coverage by 0%.
Report is 1 commits behind head on master.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #991   +/-   ##
=====================================
- Coverage      23%    23%   -0%     
=====================================
  Files         143    143           
  Lines        4351   4355    +4     
=====================================
  Hits          959    959           
- Misses       3392   3396    +4     

@LuisDuarte1 LuisDuarte1 merged commit 60bc6ae into master Oct 2, 2023
6 checks passed
@LuisDuarte1 LuisDuarte1 deleted the hotfix/set-stcp-certificate-as-trusted branch October 2, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bus APIs are not responding
3 participants