Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sigarra files api #963

Merged
merged 43 commits into from
Feb 12, 2024
Merged

Sigarra files api #963

merged 43 commits into from
Feb 12, 2024

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Sep 23, 2023

Closes #939

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@DGoiana DGoiana linked an issue Sep 23, 2023 that may be closed by this pull request
Sigarra Files API #939
Closed
@DGoiana
Copy link
Collaborator Author

DGoiana commented Sep 24, 2023

Currently files page state.

@thePeras
Copy link
Member

What do you think of adding am icon on the left of the name?
Do all files are pdfs?
If not, we can have multiple icon based on the file type

bdmendes
bdmendes requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Encapsulate the files list type
  • Use getWithCookies to retrieve the raw response
  • Use the response bytes to save the file
  • Open the saved file

@DGoiana
Copy link
Collaborator Author

DGoiana commented Sep 28, 2023

Current page state

Screenshot 2023-09-28 at 13 07 33

@DGoiana
Copy link
Collaborator Author

DGoiana commented Oct 5, 2023

bdmendes
bdmendes reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From meeting:

  • Use last updated file date to avoid caching of outdated files
  • Use pulse animation to indicate file download (maybe create a new common widget)
  • Implement file cleanup logic (globally, as a schedule? Is that native somehow?)

bdmendes
bdmendes requested changes Jan 6, 2024
View reviewed changes
uni/lib/controller/cleanup.dart Outdated Show resolved Hide resolved
uni/lib/controller/local_storage/preferences_controller.dart Outdated Show resolved Hide resolved
@thePeras thePeras requested a review from bdmendes January 8, 2024 21:17
@DGoiana DGoiana requested a review from a team January 22, 2024 12:18
Process-ing
Process-ing approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@Process-ing Process-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have one question:

uni/lib/view/course_unit_info/widgets/course_unit_files_row.dart Outdated Show resolved Hide resolved
@bdmendes bdmendes merged commit 41a5b44 into develop Feb 12, 2024
6 checks passed
@bdmendes bdmendes deleted the feature/sigarra-files branch February 12, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdmendes bdmendes bdmendes approved these changes

@Process-ing Process-ing Process-ing approved these changes

@thePeras thePeras Awaiting requested review from thePeras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sigarra Files API
4 participants
@DGoiana @thePeras @Process-ing @bdmendes