Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Launch url with toast #724

Closed
wants to merge 1 commit into from
Closed

Feature/Launch url with toast #724

wants to merge 1 commit into from

Conversation

rubuy-74
Copy link
Contributor

Closes #544
Method that checks if the user's device can open a link (canLaunchUrl) and displays an toastMessage error if it can't.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@rubuy-74 rubuy-74 changed the title Feature/launch url with toast Feature/Launch url with toast Feb 21, 2023
@rubuy-74 rubuy-74 requested review from bdmendes, marianalt and coutinho21 and removed request for bdmendes and marianalt February 25, 2023 12:53
bdmendes
bdmendes requested changes Apr 30, 2023
View reviewed changes
uni/lib/view/common_widgets/url_launcher.dart Outdated Show resolved Hide resolved
uni/lib/view/common_widgets/url_launcher.dart Outdated Show resolved Hide resolved
@bdmendes bdmendes self-requested a review July 12, 2023 14:24
@bdmendes bdmendes added this to the Mid-Summer 2023 Release milestone Jul 12, 2023
@rubuy-74 rubuy-74 requested a review from bdmendes July 28, 2023 13:21
@codecov
Copy link

codecov bot commented Aug 13, 2023 •
edited
Loading

Codecov Report

Merging #724 (ee4a1fc) into develop (012aa85) will decrease coverage by 0%.
Report is 41 commits behind head on develop.
The diff coverage is 27%.

Additional details and impacted files 
@@          Coverage Diff           @@
##           develop   #724   +/-   ##
======================================
- Coverage       23%    22%   -0%     
======================================
  Files          143    144    +1     
  Lines         4349   4359   +10     
======================================
- Hits           964    958    -6     
- Misses        3385   3401   +16

@rubuy-74 rubuy-74 requested a review from bdmendes August 23, 2023 09:54
@rubuy-74 rubuy-74 requested a review from bdmendes August 31, 2023 05:01
bdmendes
bdmendes requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase this into a single commit?

uni/lib/controller/networking/url_launcher.dart Show resolved Hide resolved
bdmendes
bdmendes previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@rubuy-74 rubuy-74 requested a review from bdmendes October 2, 2023 12:07
@rubuy-74 rubuy-74 requested a review from bdmendes October 3, 2023 14:22
@rubuy-74 rubuy-74 force-pushed the feature/launch_url_with_toast branch from 172d3a7 to ee4a1fc Compare October 6, 2023 13:58
@rubuy-74 rubuy-74 changed the base branch from develop to master October 6, 2023 14:02
@rubuy-74 rubuy-74 changed the base branch from master to develop October 6, 2023 14:04
@rubuy-74
Copy link
Contributor Author

rubuy-74 commented Oct 6, 2023

This PR continues in #1005

@rubuy-74 rubuy-74 closed this Oct 6, 2023
@rubuy-74 rubuy-74 deleted the feature/launch_url_with_toast branch October 6, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coutinho21 coutinho21 Awaiting requested review from coutinho21

@bdmendes bdmendes Awaiting requested review from bdmendes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Back to School 2023
Development

Successfully merging this pull request may close these issues.

Can't launch url ToastMessage error
2 participants
@rubuy-74 @bdmendes