Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new restaurants api #1393

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Conversation

HenriqueSFernandes
Copy link
Contributor

@HenriqueSFernandes HenriqueSFernandes commented Nov 18, 2024

WIP implementation of the new restaurants API.
It includes changes that will be undone before the merge, such as changing the provider to always fetch from the remote and debug print messages.
Currently, the meals page includes every establishment from SASUP, but it uses the menu from the old Excel file.

Closes #1360
[Description of the changes proposed in the pull request. Include steps to replicate the behavior and screenshots if UI is updated]

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@HenriqueSFernandes HenriqueSFernandes linked an issue Nov 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 12%. Comparing base (bc5ba1c) to head (5b2568d).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1393   +/-   ##
=======================================
- Coverage       12%     12%   -0%     
=======================================
  Files          265     265           
  Lines         7209    7223   +14     
=======================================
  Hits           806     806           
- Misses        6403    6417   +14     
---- 🚨 Try these New Features:

@HenriqueSFernandes
Copy link
Contributor Author

HenriqueSFernandes commented Nov 18, 2024

It seems to be working with the meals hardcoded (using week 40), but there is a problem with saving the meals in the local storage. From what I can see, that problem already existed before.

When calling db.saveIfPersistentSession(restaurants):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fetch sheet code and implement new menu's api
1 participant