Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum ios version and connectivity_plus #1010

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Bump minimum ios version and connectivity_plus #1010

merged 2 commits into from
Oct 9, 2023

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Oct 9, 2023 •
edited
Loading

Closes #1011
Minimum ios deployment target bump and also connectivity_plus package due to an error associated with xcode 15.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@DGoiana DGoiana changed the base branch from develop to master October 9, 2023 14:31
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #1010 (985cd2b) into master (c7ed168) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #1010   +/-   ##
======================================
  Coverage      16%     16%           
======================================
  Files         201     201           
  Lines        6361    6361           
======================================
  Hits          986     986           
  Misses       5375    5375

LuisDuarte1
LuisDuarte1 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯good job, xcode is my favorite build system 😍

@LuisDuarte1 LuisDuarte1 merged commit 6ef9a17 into master Oct 9, 2023
6 checks passed
@LuisDuarte1 LuisDuarte1 deleted the fix/min-ios-version-bump branch October 9, 2023 15:11
@LuisDuarte1 LuisDuarte1 mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

@limwa limwa limwa approved these changes

@bdmendes bdmendes Awaiting requested review from bdmendes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DGoiana @limwa @LuisDuarte1