Merge branch 'develop' into fix/Controller-Dispose-method

NIAEFEUP · Nov 12, 2024 · a816818 · a816818
2 parents df701d8 + e30a31c
commit a816818
Show file tree

Hide file tree

Showing 7 changed files with 58 additions and 42 deletions.
diff --git a/packages/uni_app/app_version.txt b/packages/uni_app/app_version.txt
@@ -1 +1 @@
-1.10.0-beta.35+338
+1.10.0-beta.36+339
diff --git a/packages/uni_app/lib/model/entities/login_exceptions.dart b/packages/uni_app/lib/model/entities/login_exceptions.dart
diff --git a/packages/uni_app/lib/session/exception.dart b/packages/uni_app/lib/session/exception.dart
@@ -1,4 +1,5 @@
 enum AuthenticationExceptionType {
+  internetError,
   wrongCredentials,
   expiredCredentials,
   other,

diff --git a/packages/uni_app/lib/session/flows/credentials/request.dart b/packages/uni_app/lib/session/flows/credentials/request.dart
@@ -1,3 +1,4 @@
+import 'dart:async';
 import 'package:http/http.dart' as http;
 import 'package:uni/controller/fetchers/faculties_fetcher.dart';
 import 'package:uni/session/exception.dart';
@@ -35,11 +36,20 @@ class CredentialsSessionRequest extends SessionRequest {
           'Failed to authenticate user',
           AuthenticationExceptionType.expiredCredentials,
         );
-      } else {
+      } else if (failureReason == LoginFailureReason.internetError) {
+        throw const AuthenticationException(
+          'Failed to authenticate user',
+          AuthenticationExceptionType.internetError,
+        );
+      } else if (failureReason == LoginFailureReason.wrongCredentials) {
         throw const AuthenticationException(
           'Failed to authenticate user',
           AuthenticationExceptionType.wrongCredentials,
         );
+      } else {
+        throw const AuthenticationException(
+          'Failed to authenticate user',
+        );
       }
     }
 

diff --git a/packages/uni_app/lib/sigarra/endpoints/html/authentication/login/response.dart b/packages/uni_app/lib/sigarra/endpoints/html/authentication/login/response.dart
@@ -8,6 +8,7 @@ class LoginResponse extends SigarraResponse {
 
 enum LoginFailureReason {
   serverError,
+  internetError,
   wrongCredentials,
   expiredCredentials,
   blockedAccount,

diff --git a/packages/uni_app/lib/view/login/login.dart b/packages/uni_app/lib/view/login/login.dart
@@ -9,9 +9,9 @@ import 'package:sentry_flutter/sentry_flutter.dart';
 import 'package:uni/app_links/uni_app_links.dart';
 import 'package:uni/controller/networking/url_launcher.dart';
 import 'package:uni/generated/l10n.dart';
-import 'package:uni/model/entities/login_exceptions.dart';
 import 'package:uni/model/providers/startup/session_provider.dart';
 import 'package:uni/model/providers/state_providers.dart';
+import 'package:uni/session/exception.dart';
 import 'package:uni/session/flows/credentials/initiator.dart';
 import 'package:uni/session/flows/federated/initiator.dart';
 import 'package:uni/utils/constants.dart';
@@ -99,36 +99,51 @@ class LoginPageViewState extends State<LoginPageView>
             _loggingIn = false;
           });
         }
-      } catch (err, st) {
+      } on AuthenticationException catch (err, st) {
         setState(() {
           _loggingIn = false;
         });
-        if (err is ExpiredCredentialsException) {
-          _updatePasswordDialog();
-        } else if (err is InternetStatusException) {
-          if (mounted) {
-            unawaited(
-              ToastMessage.warning(
-                context,
-                S.of(context).internet_status_exception,
-              ),
-            );
-          }
-        } else if (err is WrongCredentialsException) {
-          if (mounted) {
-            unawaited(
-              ToastMessage.error(
-                context,
-                S.of(context).wrong_credentials_exception,
-              ),
-            );
-          }
-        } else {
-          Logger().e(err, stackTrace: st);
-          unawaited(Sentry.captureException(err, stackTrace: st));
-          if (mounted) {
-            unawaited(ToastMessage.error(context, S.of(context).failed_login));
-          }
+
+        switch (err.type) {
+          case AuthenticationExceptionType.expiredCredentials:
+            _updatePasswordDialog();
+          case AuthenticationExceptionType.internetError:
+            if (mounted) {
+              unawaited(
+                ToastMessage.warning(
+                  context,
+                  S.of(context).internet_status_exception,
+                ),
+              );
+            }
+          case AuthenticationExceptionType.wrongCredentials:
+            if (mounted) {
+              unawaited(
+                ToastMessage.error(
+                  context,
+                  S.of(context).wrong_credentials_exception,
+                ),
+              );
+            }
+          default:
+            Logger().e(err, stackTrace: st);
+            unawaited(Sentry.captureException(err, stackTrace: st));
+            if (mounted) {
+              unawaited(
+                ToastMessage.error(context, S.of(context).failed_login),
+              );
+            }
+        }
+      }
+      // Handles other unexpected exceptions
+      catch (err, st) {
+        setState(() {
+          _loggingIn = false;
+        });
+        Logger().e(err, stackTrace: st);
+        unawaited(Sentry.captureException(err, stackTrace: st));
+        if (mounted) {
+          unawaited(ToastMessage.error(context, S.of(context).failed_login));
         }
       }
     }

diff --git a/packages/uni_app/pubspec.yaml b/packages/uni_app/pubspec.yaml
@@ -7,7 +7,7 @@ publish_to: "none" # We do not publish to pub.dev
 # To change it manually, override the value in app_version.txt.
 # The app version code is automatically also bumped by CI.
 # Do not change it manually.
-version: 1.10.0-beta.35+338
+version: 1.10.0-beta.36+339
 
 environment:
   sdk: ">=3.4.0 <4.0.0"