Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mongoose version to accomodate MongoDB Atlas changes #345

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Naapperas
Copy link
Member

MongoDB announced that Atlas would be migrating all database instances to version 7 of MongoDB.

This PR updates mongoose and the code accordingly to reflect the changes made (since this is potentially bumping 2 major versions).

There is no need to change the docker-compose.yaml file since it pulls from the untagged mongo image, aka, the latest image available on Docker Hub. I already checked and, on my machine, the image, when running mongosh, runs server version 7.x, which is what we want.

Copy link

render bot commented Jan 31, 2024

@Naapperas Naapperas changed the title Deps/bump mongoose Bump mongoose version to accomodate MongoDB Atlas changes Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (81bce7c) 90.33% compared to head (0e594f0) 90.27%.

Files Patch % Lines
src/config/passport.js 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #345      +/-   ##
===========================================
- Coverage    90.33%   90.27%   -0.06%     
===========================================
  Files           54       54              
  Lines         1469     1471       +2     
  Branches       245      244       -1     
===========================================
+ Hits          1327     1328       +1     
- Misses         137      138       +1     
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Naapperas
Copy link
Member Author

Audit fails due to this, which was only reported 11 hours ago, will need to wait for a fix 💀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant