Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compute log10(chl) for small chl #305

Merged
merged 2 commits into from
Oct 3, 2024

Commits on Sep 27, 2024

  1. Don't compute log10(chl) for small chl

    if chl <= chl_min, we already have log10(chl_min) stored as a parameter.
    Avoiding the computation of log10(chl) in those cases prevents the possibility
    of a floating point exception, and lets us replace a max() statement with an if
    check so it shouldn't affect performance.
    
    This requires adding chl_min to the optics_type (which already has log10chl_min
    and log10chl_max).
    mnlevy1981 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5726d94 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Avoid chl=0 in lookup_ohlmann_opacity()

    previous commit only avoiding log10(0) in lookup_ohlmann_swpen() but we have
    another log10(chl) in the opacity function
    mnlevy1981 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8fb8aaf View commit details
    Browse the repository at this point in the history