Changes to Docker material #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The naming we use for the Dockerfiles were not according to the official documentation. Also added a note about Dockerfile naming conventions.
The instructions for starting to build Docker images were more complicated than they needed to be for teaching the students the basics of building images, and this commit streamlines them. Things that have been removed include: - Remove redundant SHELL directive - Time zone packages - Port forwarding - Initialising Conda (not needed with Miniforge base) - Usage of `--set subdir linux-64` and `--platform linux/amd64` instructions, as they are not needed at this stage - Creating a new Conda environment and activating it instead of using the base environment Hopefully this streamlining will make the very first entry into Dockerfiles and their use easier to understand for the students.
Remove unused and redundant commands from the final Dockerfile in the container tutorial, including some of the same streamlining steps as for the earlier Dockerfiles (see a58e880).
…ucible-research into docker-changes
johnne
reviewed
Nov 15, 2024
There was a problem hiding this comment.
I modified the code here to make the sample table less cluttered. There used to be 2 lines for each sample due to the info in gsm$characteristics_ch1. Now we extract the treatment: and growth phase info and put in separate columns, resulting in a condensed table.
johnne
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes to the Docker material, including: