Added ability for .json() to accept kwargs. model.json() can now crea… #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te a pretty string with .json(indent=4)
loriab
reviewed
Mar 26, 2023
| @@ -127,6 +127,7 @@ def serialize( | |||
| exclude_unset: Optional[bool] = None, | |||
| exclude_defaults: Optional[bool] = None, | |||
| exclude_none: Optional[bool] = None, | |||
| **kwargs, | |||
There was a problem hiding this comment.
My only hesitation is because I don't know if serialize was written w/o kwargs as a defensive measure. Certainly the indentation use to which you've put kwargs is reasonable and harmless, though. @bennybp, any complications to the database if formats can change through this?
There was a problem hiding this comment.
I don't believe this will cause any problems on my end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te a pretty string with .json(indent=4)
Description
The current implementation of
serializedoes not accept generickwargs, so we loose the basic ability to modify serialized output, like pretty printing a json string withmodel.json(indent=4). I'm implemented serialize to be slightly more generic so we maintain functionality described in the pydantic docsChangelog description
Added ability for .json() to accept kwargs. model.json() can now create a pretty string with .json(indent=4)
Status