Skip to content

Commit

Permalink
Fix Docker builds after upgrade to 1.23 (#153)
Browse files Browse the repository at this point in the history
  • Loading branch information
iogakos authored Sep 2, 2024
1 parent 3829fcf commit 3cbefb6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ sudo /opt/metrikad/metrikad-{protocol} --version
### Development environment
To work on an agent development you will need:
* GNU `make`
* Go `1.18` or later
* Go `1.23` or later

To ensure everything is set up correctly, simply run `make build`, which should build every metrika agent binary version for your architecture.

Expand All @@ -52,4 +52,4 @@ Exporters can be implemented to encode the data in any desirable format and prod

`exporter.HandleMessage()` method will be called for every Message (Metric or Event) arriving from the Agent watchers. If the exporter implementation cannot keep up with the data flow, newly collected Messages will eventually be dropped. As such, it's recommended to implement buffering in the exporter implementation.

Exporters are implemented under [contrib](internal/pkg/contrib) package, and an exporter constructor must be registered with `ExportersMap` variable in [exporter.go](internal/pkg/contrib/exporter.go).
Exporters are implemented under [contrib](internal/pkg/contrib) package, and an exporter constructor must be registered with `ExportersMap` variable in [exporter.go](internal/pkg/contrib/exporter.go).
4 changes: 2 additions & 2 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# syntax=docker/dockerfile:1
FROM --platform=$BUILDPLATFORM golang:1.18.6 as builder-amd64
FROM --platform=$BUILDPLATFORM golang:1.22.6 as builder-amd64
ENV CC "gcc"

FROM --platform=$BUILDPLATFORM golang:1.18.6 as builder-arm64
FROM --platform=$BUILDPLATFORM golang:1.22.6 as builder-arm64
ENV CC "aarch64-linux-gnu-gcc"
ENV CGO_ENABLED "1"

Expand Down

0 comments on commit 3cbefb6

Please sign in to comment.