Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding react Text component to design-system-react #110

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

georgewrmarshall
Copy link
Contributor

Description

This PR adds a Text component to the design-system-react library, introducing a reusable typography component for MetaMask’s design system.

Related issues

Fixes: https://github.com/metamask/metamask-design-system/issues#workspaces/design-system-61e8a2ae77c3a60012e5003c/issues/zh/762

Manual testing steps

  1. Run storybook yarn storybook
  2. Navigate to a Text component
  3. Verify the text styling, ensuring consistency with design specifications.
  4. Confirm that accessibility standards are met, including font size, color contrast, and screen reader support.

Screenshots/Recordings

After

after1080.mov

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and/or screenshots.

@georgewrmarshall georgewrmarshall self-assigned this Nov 13, 2024
@georgewrmarshall georgewrmarshall changed the title Fix/react text feat: Adding react Text component to design-system-react Nov 13, 2024
Copy link

socket-security bot commented Nov 14, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@vitejs/[email protected] Transitive: environment +1 96.7 kB vitebot
npm/[email protected] None 0 712 kB dcas

View full report↗︎

@georgewrmarshall georgewrmarshall force-pushed the fix/react-text branch 2 times, most recently from b2bb251 to 7ae23d6 Compare November 15, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant