issue:4151975-Log analyzer telemetry file extract #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmufeld
reviewed
Nov 6, 2024
| @@ -125,7 +125,18 @@ def full_analysis(self): | |||
| Run all the analysis and returns a list of all the graphs created and their title | |||
| """ | |||
| for func in self._funcs_for_analysis: | |||
| func() | |||
| try: | |||
There was a problem hiding this comment.
I think you should add documentation
| logs_with_dirs[dir_name].add(base_name) | ||
| else: | ||
| single_name_logs.add(base_name) | ||
| return single_name_logs, logs_with_dirs |
There was a problem hiding this comment.
I wish someone will love me as you love tuples
There was a problem hiding this comment.
What is a tuple? do explain!
I think it is one of the nice benefits python gives...
| files_to_extract = set(files_to_extract) | ||
| directories_to_extract = set(directories_to_extract) | ||
| found_files = set() | ||
| not_found_files = set(files_to_extract) | ||
| _, logs_with_dirs = self._split_based_on_dir(files_to_extract) |
There was a problem hiding this comment.
why _?
please rename to a meaningfull name
There was a problem hiding this comment.
Since it is not used.
This function returns 2 items, for this case one is not needed but for the other cases it is needed
anasbadaha
reviewed
Nov 6, 2024
anasbadaha
approved these changes
Nov 7, 2024
shmufeld
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Extracting telemetry logs
Why ?
We need them in order to support analysis of them
How ?
Adding support to extract them from tar/directory.
Testing ?
Local testing with dump + directory.
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests