4099606: PDR plugin: Traceback: AttributeError: 'dict' object has no attribute 'active_speed' #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vg12345
requested review from
TalLerner,
drorlevy,
egershonNvidia and
ananalaghbar
and removed request for
drorlevy
egershonNvidia
approved these changes
Oct 1, 2024
TalLerner
approved these changes
Oct 1, 2024
ananalaghbar
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix for Traceback: AttributeError: 'dict' object has no attribute 'active_speed' in PDR plugin
Cosmetic changes in logged text messages
Why ?
4099606
When plugin is disable and then enabled with changing to topology, there is Traceback with error:
AttributeError: 'dict' object has no attribute 'active_speed' in PDR plugin
pdr_deterministic_plugin 6.log
How ?
Object of wrong type has been added to ports_data.
Fix adds object of correct type
Testing ?
Manual testing for bug fix
Automatic testing for regression
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests