issue:4050338 Add link flapping to log analyzer #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmufeld
reviewed
Sep 2, 2024
plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/base_analyzer.py
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/base_analyzer.py
Outdated
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/link_flapping_analyzer.py
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/link_flapping_analyzer.py
Outdated
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/link_flapping_analyzer.py
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/link_flapping_analyzer.py
Outdated
Show resolved
Hide resolved
ananalaghbar
reviewed
Sep 2, 2024
plugins/ufm_log_analyzer_plugin/src/loganalyze/logs_extraction/directory_extractor.py
Show resolved
Hide resolved
shmufeld
approved these changes
Sep 4, 2024
plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/link_flapping_analyzer.py
Show resolved
Hide resolved
atolikin94
reviewed
Sep 4, 2024
plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/link_flapping_analyzer.py
Show resolved
Hide resolved
shmufeld
approved these changes
Sep 9, 2024
|
I spoke with @atolikin94 and got his verbal approval to merge it. He is on vacation with no access to his computer to do the formal approve |
|
as both @shmufeld and @atolikin94 approved this, I'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why ?
Adding more analysis to the tool
How ?
Using the link flapping logic: extracting the second telemetry samples and using them. Taking the latest telemetry and the one from one week before for the analysis.
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests