-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue:4043385: [UFM Events Grafana Dashboard Plugin]: Collecting the telemetry and write it to Prometheus DB #240
Open
ananalaghbar
wants to merge
6
commits into
Mellanox:main
Choose a base branch
from
ananalaghbar:4040988#prometheus_in_grafana
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…python application infra for collecting configurable telemetry endpoint - issue:4040988: [UFM Events Grafana Dashboard Plugin]: Installing the Prometheus server and store partial secondary telemetry data (only data that we need to present in Grafana) in Prometheus DB
boazhaim
reviewed
Aug 26, 2024
plugins/ufm_events_grafana_dashboard_plugin/src/ufm_events_grafana_dashboard/app.py
Show resolved
Hide resolved
..._grafana_dashboard_plugin/src/ufm_events_grafana_dashboard/data/collectors/base_collector.py
Outdated
Show resolved
Hide resolved
...ts_grafana_dashboard_plugin/src/ufm_events_grafana_dashboard/data/listeners/base_listener.py
Show resolved
Hide resolved
...oard_plugin/src/ufm_events_grafana_dashboard/data/listeners/telemetry_prometheus_exporter.py
Outdated
Show resolved
Hide resolved
...oard_plugin/src/ufm_events_grafana_dashboard/data/listeners/telemetry_prometheus_exporter.py
Outdated
Show resolved
Hide resolved
...oard_plugin/src/ufm_events_grafana_dashboard/data/listeners/telemetry_prometheus_exporter.py
Outdated
Show resolved
Hide resolved
...events_grafana_dashboard_plugin/src/ufm_events_grafana_dashboard/prometheus/prometheus.proto
Show resolved
Hide resolved
…nting python application infra for collecting configurable telemetry endpoint
…ing the Prometheus server and store partial secondary telemetry data (only data that we need to present in Grafana) in Prometheus DB
boazhaim
approved these changes
Aug 28, 2024
boazhaim
reviewed
Aug 29, 2024
plugins/ufm_events_grafana_dashboard_plugin/scripts/entrypoint.sh
Outdated
Show resolved
Hide resolved
boazhaim
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ?
This PR introduces the mechanism for periodically collecting data from the secondary telemetry endpoint and recording the predefined metrics (starting with Link_Down as POC) in specified Prometheus DB (defaulting to the local DB).
Why ?
To enhance the current Grafana dashboard for UFM events, we need to incorporate telemetry as an additional data source. This integration allows us to create a hybrid dashboard that combines event data with telemetry metrics, providing a more in-depth view of the fabric's status.
How ?
Collecting both UFM events and the UFM telemetry metrics allows us to create Grafana panels that display events alongside corresponding telemetry data. This functionality allows for detailed drill-downs into telemetry metrics directly related to specific events.
A new dashboard template will be introduced in a separate PR.
Special triggers
Use the following phrases as comments to trigger different runs
bot:retest
rerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgrade
run additional update tests