Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: fix fuse errors #194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vjardin
Copy link

@vjardin vjardin commented Oct 15, 2024

Fix the following syntax errors:
...
checking for fuse... yes
./configure: line 5243: test: =: unary operator expected
checking for pthread_create in -lpthread... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
...

I will not check it for Freebsd or other OS, but there is obviously something wrong with the syntax.

@vjardin
Copy link
Author

vjardin commented Nov 2, 2024

Please, any comments ?

@vjardin
Copy link
Author

vjardin commented Nov 6, 2024

@vladsokolovsky : any comments ? It is a minor fix, but I guess it does not hurt.

@vjardin
Copy link
Author

vjardin commented Nov 12, 2024

please @pgeng-nv, any review ?

configure.ac Outdated Show resolved Hide resolved
Fix the following syntax errors:
  ...
 checking for fuse... yes
 ./configure: line 5243: test: =: unary operator expected
 checking for pthread_create in -lpthread... yes
 checking that generated files are newer than configure... done
 configure: creating ./config.status
  ...
Copy link
Collaborator

@lsun100 lsun100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this repo is only maintained internally. To make it simpler, do you mind opening an Issue (https://github.com/Mellanox/rshim-user-space/issues) with the proposed fix included?

@vjardin
Copy link
Author

vjardin commented Nov 13, 2024

Currently this repo is only maintained internally. To make it simpler, do you mind opening an Issue (https://github.com/Mellanox/rshim-user-space/issues) with the proposed fix included?

No way, you have the pull request so what's wrong ?

@lsun100
Copy link
Collaborator

lsun100 commented Nov 15, 2024

Please, any comments ?

We're in the process of updating the LICENSE file. Can we hold this pull request for now? Once the LICENSE file is updated, it'll be much easier to accept external contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants