Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supported-nic-firmware in a helm chart #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Nov 13, 2024

This is a follow-up PR for #49

This is a follow-up PR for Mellanox#49

Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11814494725

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 58.878%

Files with Coverage Reduction New Missed Lines %
internal/controller/nicdevice_controller.go 5 77.14%
internal/controller/nicconfigurationtemplate_controller.go 6 87.06%
Totals Coverage Status
Change from base Build 11781498723: -0.4%
Covered Lines: 1794
Relevant Lines: 3047

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants