Makefile.am, configure.ac: fix hard coded static and include path #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjardin
force-pushed
the
fix_br_makefile
branch
from
6562926
to
30c4bb2
Compare
|
Side note : without this patch, it cannot link because |
I do not understand why some -static are enforced while dynamic linkage could be used. We should not have any -static in order to be able to link for the targets.
It is not compliant with cross compilation, it will lead to the following: aarch64-buildroot-linux-gnu-g++ -c -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g0 -D_FORTIFY_SOURCE=1 -DHAVE_TERMIOS_H -DHAVE_SYS_PCI_H -isystem /usr/include/libxml2 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 conftest.cpp aarch64-buildroot-linux-gnu-g++: ERROR: unsafe header/library path used in cross-compilation: '-isystem' '/usr/include/libxml2' configure.ac: proper probe libxml2 libxml2: CFLAGS and CXXFLAGS are used Makefiles are not using xml_CFLAGS
the include path cannot be hardcoded with: /usr/include/curl/
engine is exported by openssl/engine.h ; if not, we can have some compilation warnings of some undefined symbols.
vjardin
force-pushed
the
fix_br_makefile
branch
from
8e860d7
to
9990de4
Compare
vjardin
changed the title
Thanks to this definition, we'll be able to ave cleaner Makefiles.
the .so file should remain for the target when dynamic linkage is used. If the file is removed, none of the applications will be loadable.
start using DYNAMIC in order to be aligned with the --enable-all-static argument.
vjardin
force-pushed
the
fix_br_makefile
branch
from
2731a2c
to
cbc9640
Compare
DPDK assumes that the library shall be into /usr/lib instead of /usr/lib/mstflint/
|
Meanwhile, this pull request is included with the Buildroot package until it'll become mainstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serie is used to avoid hard coded path that do not work for any distributions. For instance, when buildroot is used or when cross compilation is used, the path of the headers cannot be enforce with /usr/include .