Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude InvalidApPostException from rolling back the transaction #1180

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

BentiGorlich
Copy link
Member

Overwrite the default workWrapper method so the transactional method is not called. Instead implement a custom behaviour that does not roll back the db changes if the exception was a InvalidApPostException

@BentiGorlich BentiGorlich added bug Something isn't working backend Backend related issues and pull requests labels Oct 10, 2024
@BentiGorlich BentiGorlich added this to the v1.7.3 milestone Oct 10, 2024
@BentiGorlich BentiGorlich self-assigned this Oct 10, 2024
@BentiGorlich
Copy link
Member Author

why did my commit not dismiss your review 🤔

@melroy89
Copy link
Member

why did my commit not dismiss your review 🤔

Because of:
image

But I trust you.

@BentiGorlich
Copy link
Member Author

Thanks for that :D
But I think this box should be ticked. What do you think?

@melroy89
Copy link
Member

Thanks for that :D But I think this box should be ticked. What do you think?

Yea maybe, if you want more work 😆

@BentiGorlich BentiGorlich merged commit 077d369 into main Oct 10, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the fix/dead-instances-db-write branch October 10, 2024 14:51
@melroy89
Copy link
Member

I checked the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants