Fix composer packages to pass twig linter #1016
Draft
+522
−272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
melroy89,
asdfzdfj,
BentiGorlich,
jwr1 and
e-five256
ghost
self-assigned this
|
@melroy89 looks like our ci/cd images need to be updated to include the php |
|
I'd vote for including a twig linter :) |
|
I updated the Docker CI image and tagged it as v1.2.0. |
This reverts commit 49b00f7.
melroy89
force-pushed
the
fix_twig_lint
branch
from
fcf4413
to
3a2c6e7
Compare
melroy89
added a commit
to MbinOrg/psalm-github-security-scan
that referenced
this pull request
Sep 2, 2024
Add XSL for PR: MbinOrg/mbin#1016
|
Docker file changes are merged to main via: #1078. We can later dive deeper why this is still giving errors. |
|
This PR is stale because it has been open 40 days with no activity. |
|
composer.lock has too many conflicts, not doing to fix that manually.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
@melroy89 maybe we should add
php bin/console lint:twigto our CI/CD checks? https://symfony.com/doc/current/templates.html#linting-twig-templates