-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging implementation for mapping on Apple and Non-Apple OSs #21
base: develop
Are you sure you want to change the base?
Conversation
Thanks for your help with this. I took a quick look at it and there seems to be some misunderstanding with respect to this. First, as of right now, the issue has a "draft" tag, which means that it's still being worked on before others can consider tackling it. However, I'll leave this pull request in here. Once that tag goes away, people can begin to solve the issues. Second, as stated in the Contributing Guidelines, you need to put your pull requests in the Third, and finally, the current file you've edited, |
Basic logging messages have been added to the classes across the library. The commits have been separated by a per-file basis to try to make the PR more reviewable. Please let me know if there are more areas to improve the logs. |
Anything other than Other than that, this is looking good, I think! 👍 |
Quick update on this PR, I have been busy the past week or so, but plan to get back to editing this likely tomorrow. Sorry about the delay to looking into this PR and getting the implementation completed. |
Description
Attempt for a logging implementation that maps to either the standard Apple logger if building for an Apple-OS target or the SwiftLogger library if the target is a non-Apple OS
Linked Issues
#18
Type of Change
Checklist:
Screenshots (if applicable)
Attach any screenshots or GIFs showcasing the changes effect.
Additional Notes
Add any other notes about the Pull Request here.
Credits
If you want to be credited in the CONTRIBUTORS file, you can fill out the form below. Please don't remove the square brackets.