-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate verify=False from session to requests #387
base: master
Are you sure you want to change the base?
Propagate verify=False from session to requests #387
Conversation
@phinds1 would be very useful a test that shows the bug and your PR that fixes the test. |
Are there unit tests somewhere? Or integration test framework that could have a broken SSL server added? I didn't add a feature, its just a bug fix, so there should be no more or less test coverage. |
An integration test is quite hard to develop in this case, I've on my list. |
@@ -34,6 +34,8 @@ def _common_request( | |||
|
|||
self._capture_output() | |||
|
|||
kwargs.update({'verify': session.verify}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break session less keywords (session is not defined in this case), and should not be necessary when the session has verify=False
I just tested this and it works as expected.
|
ref: https://forum.robotframework.org/t/how-to-make-requests-library-ignore-ssl-errors/6790
ref: #386