fix: status should be evaluate latest response if failed #383

MarketSquare · Nov 14, 2023 · 40faddf · 40faddf
1 parent 1b1b617
commit 40faddf
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/atests/issues/334.robot b/atests/issues/334.robot
@@ -0,0 +1,13 @@
+*** Settings ***
+Library    RequestsLibrary
+Resource  ../res_setup.robot
+
+Suite Setup     Setup Flask Http Server
+Suite Teardown  Teardown Flask Http Server And Sessions
+
+*** Test Cases ***
+
+Test evaluated response is always the one passed
+    ${response_error}=  GET On Session  ${GLOBAL_SESSION}  url=/status/404    expected_status=any
+    ${response_ok}=     GET On Session  ${GLOBAL_SESSION}  url=/status/200    expected_status=any
+    Status Should Be    404    ${response_error}
diff --git a/atests/test_status_assertions.robot b/atests/test_status_assertions.robot
@@ -5,7 +5,6 @@ Resource  res_setup.robot
 Suite Setup     Setup Flask Http Server
 Suite Teardown  Teardown Flask Http Server And Sessions
 
-
 *** Test Cases ***
 
 Request And Status Should Be Different

diff --git a/src/RequestsLibrary/RequestsKeywords.py b/src/RequestsLibrary/RequestsKeywords.py
@@ -116,7 +116,7 @@ def status_should_be(self, expected_status, response=None, msg=None):
         |       ELSE
         |        [...]
         """
-        if not response:
+        if response is None:
             response = self.last_response
         self._check_status(expected_status, response, msg)
 

diff --git a/src/RequestsLibrary/version.py b/src/RequestsLibrary/version.py
@@ -1 +1 @@
-VERSION = '0.9.5'
+VERSION = '0.9.6'