Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add slot time flag #51

Merged

Conversation

thedevbirb
Copy link
Contributor

@thedevbirb thedevbirb commented Apr 26, 2024

Disclaimer: I first opened this by mistake (and closed it immediately after) but I thought it might be useful.

This PR introduce an extra flag --slot-time that allows to send spam transactions more often in configurations where the slot time is different than 12 seconds, the current hardcoded value.
It should not be a breaking change since the default value is set to its current usage of 12 seconds

@thedevbirb thedevbirb closed this Apr 26, 2024
@thedevbirb thedevbirb reopened this Apr 26, 2024
@thedevbirb thedevbirb changed the title feat: add slot time as flag feat: add slot time flag Apr 28, 2024
Copy link
Owner

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@MariusVanDerWijden MariusVanDerWijden merged commit 75cb788 into MariusVanDerWijden:master May 10, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants