-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering loop to experimental #3707
Merged
MrDiver
merged 40 commits into
ManimCommunity:experimental
from
JasonGrace2282:render-manager
May 2, 2024
Merged
Add rendering loop to experimental #3707
MrDiver
merged 40 commits into
ManimCommunity:experimental
from
JasonGrace2282:render-manager
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This is likely to be a very bug-prone commit
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…non-existing opacity
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in the rendering loop. TL;DR, the following now works
The camera and interactivity still need to be added
Breaking Changes
OpenGLCameraFrame
was renamed toCamera
.Animation
and :class:.Scene
#3695 ChangesCompleted
RenderManager
Animation
fromScene
Experimental Progress Tracker #3817
TBD
These are TODOs for Experimental, not neccessarily for this PR
Mobject.points
) to be relative to center of Mobjectmain
(likely after this PR is merged)RenderManager
manageScene
andWindow
instead ofScene
managingRenderManager
andWindow