-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Expression editor conversion from HAML to React #8944
base: master
Are you sure you want to change the base?
Conversation
Hey @amalvijayan03 , could you please update the PR description on your findings about how the expression editor works? |
UI Flow: Expression Type Selection and Editing - Selection of Expression Type:
1.Users can select expression conditions from the dropdown menus.
1. _exp_editor.html.haml: 2. _editor.html.haml: |
Checked commit amalvijayan03@94ca76d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
This pull request is not mergeable. Please rebase and repush. |
export const DateParameters = [ | ||
{ id: 'choose', label: '<choose>' }, | ||
{ id: 'thishour', label: 'This Hour' }, | ||
{ id: 'lasthour', label: 'Last Hour' }, | ||
{ id: '2hoursago', label: '2 Hours Ago' }, | ||
{ id: '3hoursago', label: '3 Hours Ago' }, | ||
{ id: '4hoursago', label: '4 Hours Ago' }, | ||
{ id: '5hoursago', label: '5 Hours Ago' }, | ||
{ id: '6hoursago', label: '6 Hours Ago' }, | ||
{ id: '7hoursago', label: '7 Hours Ago' }, | ||
{ id: '8hoursago', label: '8 Hours Ago' }, | ||
{ id: '9hoursago', label: '9 Hours Ago' }, | ||
{ id: '10hoursago', label: '10 Hours Ago' }, | ||
{ id: '11hoursago', label: '11 Hours Ago' }, | ||
{ id: '12hoursago', label: '12 Hours Ago' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can reuse this - app/helpers/view_helper.rb
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
Part of angular conversion task - Replace angular code #7603 >
/miq_ae_class/:
Automation/Automate/Explorer/Datastore -> Select a Domain -> Select a Namespace -> Select a Class -> Add a New Method / Expression Editor
Sections in Pages and its file path - #8944 (comment)