-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose MDAnalysis.topology.guessers
and MDAnalysis.guesser.tables
under MDAnalysis.topology.core
#4766
Conversation
Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-26 20:38:38 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4766 +/- ##
===========================================
+ Coverage 93.59% 93.63% +0.04%
===========================================
Files 177 189 +12
Lines 21710 22792 +1082
Branches 3052 3052
===========================================
+ Hits 20320 21342 +1022
- Misses 943 1003 +60
Partials 447 447 ☔ View full report in Codecov by Sentry. |
This should be good to go - the tests repeat stuff we already have, but it was cleaner than to have a bunch of randomly wrapped |
MDAnalysis.topology.guessers
and MDAnalysis.guesser.tables
under MDAnalysis.topology.core
MDAnalysis.topology.guessers
and MDAnalysis.guesser.tables
under MDAnalysis.topology.core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing the extra work — identifying the issue, raising issue & fixing it. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah... hadn't anticipated people might import from core. Thanks, LGTM, this seems like a good change for user experience.
Fixes #4765
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4766.org.readthedocs.build/en/4766/