Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MDAnalysis.topology.guessers and MDAnalysis.guesser.tables under MDAnalysis.topology.core #4766

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 26, 2024

Fixes #4765

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated? - not needed
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4766.org.readthedocs.build/en/4766/

@pep8speaks
Copy link

pep8speaks commented Oct 26, 2024

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 211:5: E122 continuation line missing indentation or outdented
Line 212:5: E122 continuation line missing indentation or outdented
Line 213:5: E122 continuation line missing indentation or outdented

Comment last updated at 2024-10-26 20:38:38 UTC

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (800b4b2) to head (447dff6).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4766      +/-   ##
===========================================
+ Coverage    93.59%   93.63%   +0.04%     
===========================================
  Files          177      189      +12     
  Lines        21710    22792    +1082     
  Branches      3052     3052              
===========================================
+ Hits         20320    21342    +1022     
- Misses         943     1003      +60     
  Partials       447      447              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 26, 2024

This should be good to go - the tests repeat stuff we already have, but it was cleaner than to have a bunch of randomly wrapped pytest.warns everywhere.

@IAlibay IAlibay changed the title [WIP] Expose MDAnalysis.topology.guessers and MDAnalysis.guesser.tables under MDAnalysis.topology.core Expose MDAnalysis.topology.guessers and MDAnalysis.guesser.tables under MDAnalysis.topology.core Oct 26, 2024
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing the extra work — identifying the issue, raising issue & fixing it. LGTM.

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... hadn't anticipated people might import from core. Thanks, LGTM, this seems like a good change for user experience.

@IAlibay IAlibay merged commit e776f12 into develop Oct 27, 2024
24 checks passed
@IAlibay IAlibay deleted the issue-4765 branch October 27, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guessers and tables no longer imported by default under MDAnalysis.topology
4 participants