Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Update guesser docs #4741

Closed

Conversation

lilyminium
Copy link
Member

@lilyminium lilyminium commented Oct 19, 2024

Relates to #4696

Do not merge -- I'll cherry-pick these commits into a real PR that's more easily reviewable after #3753 is merged. Just checking docs rendering for now.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4741.org.readthedocs.build/en/4741/

aya9aladdin and others added 30 commits July 25, 2022 21:22
it breaks the current behavior of guessing masses
aya9aladdin and others added 26 commits March 26, 2024 16:40
* updating some docs and removing docs of removed modules
*updating are_value_missing() method
- updated guess_TopologyAttrs docs
- fixed some tests
- capitalize atomtypes from elements in RDKitParser
Co-authored-by: Lily Wang <[email protected]>
Bumps the github-actions group with 2 updates: [actions/setup-python](https://github.com/actions/setup-python) and [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish).


Updates `actions/setup-python` from 4 to 5
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4...v5)

Updates `pypa/gh-action-pypi-publish` from 1.10.0 to 1.10.2
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.10.0...v1.10.2)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add black configuration, ignoring all files

* black

* black version

* adios 39
…lysis (MDAnalysis#4718)

- Fixes MDAnalysis#4664 
- Parallelization of the backend support to the class HydrogenBondAnalysis in hbond_analysis.py
- Moved setting up of donors and acceptors from _prepare() to __init__() (needed to make
  parallel processing work)
- Addition of parallelization tests in test_hydrogenbonds_analysis.py and fixtures in conftest.py
- Updated Changelog

---------

Co-authored-by: Yuxuan Zhuang <[email protected]>
Co-authored-by: Oliver Beckstein <[email protected]>
…alysis#4721)

- Fixes MDAnalysis#4674 
- Parallelization of the backend support to the class DSSP in dssp.py
- Addition of parallelization tests in test_dssp.py and fixtures in conftest.py
- Updated Changelog

---------

Co-authored-by: Yuxuan Zhuang <[email protected]>
* Add Python 3.13 to minimal CI testing, and include some minor test shims to accommodate.
black config

ignore formatting git blame
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 99.67949% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.62%. Comparing base (48e9e01) to head (948d75b).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
package/MDAnalysis/guesser/base.py 98.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4741      +/-   ##
===========================================
+ Coverage    93.60%   93.62%   +0.02%     
===========================================
  Files          173      187      +14     
  Lines        21464    22627    +1163     
  Branches      2993     3023      +30     
===========================================
+ Hits         20091    21185    +1094     
- Misses         929      998      +69     
  Partials       444      444              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilyminium
Copy link
Member Author

Closing to cherry-pick commits into new PR once #3753 is merged.

@lilyminium lilyminium closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants