Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug github runner timeout with tmate #4691

Closed
wants to merge 19 commits into from

Conversation

yuxuanzhuang
Copy link
Contributor

@yuxuanzhuang yuxuanzhuang commented Aug 27, 2024

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4691.org.readthedocs.build/en/4691/

@yuxuanzhuang yuxuanzhuang marked this pull request as draft August 27, 2024 07:18
Copy link

github-actions bot commented Aug 27, 2024

Linter Bot Results:

Hi @yuxuanzhuang! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ✅ Passed
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/10753691504/job/29823410650


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (d11a1ef) to head (9d99b42).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4691      +/-   ##
===========================================
- Coverage    93.87%   92.78%   -1.10%     
===========================================
  Files          173      185      +12     
  Lines        21422    22488    +1066     
  Branches      3979     3979              
===========================================
+ Hits         20110    20865     +755     
- Misses         858     1172     +314     
+ Partials       454      451       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Sep 6, 2024

Hello @yuxuanzhuang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 9:1: E302 expected 2 blank lines, found 1
Line 11:1: W293 blank line contains whitespace
Line 24:80: E501 line too long (96 > 79 characters)
Line 25:80: E501 line too long (85 > 79 characters)
Line 26:80: E501 line too long (91 > 79 characters)
Line 35:58: W292 no newline at end of file

Line 1379:1: E302 expected 2 blank lines, found 1

Line 55:1: E302 expected 2 blank lines, found 1
Line 84:1: E302 expected 2 blank lines, found 1
Line 106:1: E302 expected 2 blank lines, found 1

Comment last updated at 2024-09-07 18:51:58 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants