Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guessers and tables no longer imported by default under MDAnalysis.topology #4765

Closed
IAlibay opened this issue Oct 26, 2024 · 0 comments · Fixed by #4766
Closed

guessers and tables no longer imported by default under MDAnalysis.topology #4765

IAlibay opened this issue Oct 26, 2024 · 0 comments · Fixed by #4766

Comments

@IAlibay
Copy link
Member

IAlibay commented Oct 26, 2024

Related to #4753

Expected behavior

I'm just checking if our changes here are resolving issues with the downstream mdakits, and one thing that still seems to be broken with the API is that folks are relying on doing this:

import MDAnalysis
MDAnalysis.topology.guessers.guess_types(...)

Actual behavior

This isn't possible at the moment because we removed the imports from MDAnalysis.topology.core.

Solution

Just adding the import back in MDAnalysis.topology.core as-is won't work because import MDAnalysis will always give you a deprecation warning, which is just a terrible user experience.

Instead we should just switch all the methods under MDAnalysis.topology.guessers to use the deprecate decorator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant