Adjust provisioning profile path in script for Xcode 16 compatibility #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
• Reverted Common/Models/BuildDetails.swift to its state before the “xcode16_profile_support” merge.
• Updated Scripts/capture-build-details.sh to search for .mobileprovision files in both Xcode 15.4 and Xcode 16 locations.
Background:
Loop expects a provisioning profile expiration date even for browser builds. However, this expiration date is not available at runtime for TestFlight-deployed apps and therefore the suggested solution in "xcode16_profile_support" did not work.
To resolve this, we have reverted BuildDetails.swift and updated the .sh script to correctly locate the provisioning profile for both Xcode 15.4 and Xcode 16 without requiring changes to Loop’s runtime behavior. This avoids the need for refactoring Loop to handle missing expiration dates differently.
Testing:
• Verified with Mac Xcode 15.4 build
• Verified with Mac Xcode 16 build
• Verified with Browser Build/TestFlight-deployment